Skip to content

Upgrading to 1.3.17

Release 1.3.17 focuses on fixing a critical bug in the CSP Theme.

When updating the Hyvä Theme to version 1.3.17, please always update the hyva-themes/magento2-theme-module to the latest version.

Even if not updating the Default Theme to 1.3.17, it is safe to update the Hyva_Theme module to the latest version (package hyva-themes/magento2-theme-module).

Notable news

Please refer to the changelogs for details about the bugfixes.

Wrong old price calculation on the product detail page in the CSP Theme

This release fixes a issue where the price on the product detail page was rendired incorrectly. This was do incompatible javascript calculation do mixed input types.

Adding this fix your self without updating

Apply the following changes to your theme's in ``: 

diff --git a/Magento_Catalog/templates/product/view/price.phtml b/Magento_Catalog/templates/product/view/price.phtml
index 454bf69885cbdd00ba6dfb004f4bf55463293c4e..8ffc0ab5ab8588237578b41d53ae1a92249d89f9 100644
--- a/Magento_Catalog/templates/product/view/price.phtml
+++ b/Magento_Catalog/templates/product/view/price.phtml
@@ -250,10 +250,12 @@ if ($msrpPrice = iterator_to_array($product->getPriceInfo()->getPrices())[MsrpPr
                    this.activeProductsPriceData[this.finalPriceKey].amount < this.activeProductsPriceData[this.regularPriceKey].amount;
            },
            formatOldPriceWithOptions() {
-                return hyva.formatPrice(this.$el.dataset.oldPrice + this.getCustomOptionPrice());
+                const price = parseFloat(this.$el.dataset.oldPrice);
+                return hyva.formatPrice(price + this.getCustomOptionPrice());
            },
            formatOldPriceExclWithOptions() {
-                return hyva.formatPrice(this.$el.dataset.oldPriceExcl + this.getCustomOptionBasePrice())
+                const price = parseFloat(this.$el.dataset.oldPriceExcl);
+                return hyva.formatPrice(price + this.getCustomOptionBasePrice())
            },
            formatOldPriceInclWithSelection() {
                return hyva.formatPrice(this.activeProductsPriceData[this.regularPriceKey].amount + this.getCustomOptionPrice());

Changelogs

Changelogs are available from the CHANGELOG.md in the codebase, or here:

Tooling

Please refer to the Hyvä Theme upgrade docs for helpful information on how to upgrade.